feat(container): experimental cloudbuilder support #5928
Conversation
Experimental cloudbuilder support for test customers.
stefreak
force-pushed
the
cloudbuilder-v1
branch
from
1eb78e8 to
1efc066
Compare
stefreak
force-pushed
the
cloudbuilder-v1
branch
from
6895963 to
f93fdb4
Compare
stefreak
force-pushed
the
cloudbuilder-v1
branch
2 times, most recently
from
32d8371 to
083fc92
Compare
…ly using / downloading the tool
stefreak
force-pushed
the
cloudbuilder-v1
branch
from
083fc92 to
8420f1d
Compare
| proc.on("exit", () => { | ||
| resolve() | ||
| }) |
There was a problem hiding this comment.
Should we simplify this to be just proc.on("exit", resolve) like in the line above?
There was a problem hiding this comment.
We can do that, but that'd change the behaviour; Right now the Promise resolves to void and in your variant it'd resolve to whatever the exit event handler receives as first argument (Likely the exit code). I only added the error here as I noticed that in case of an error the Promise would never be resolved or rejected. The error event will pass the error itself to reject as first argument.
There was a problem hiding this comment.
Ah, right! Thanks for the explanation :)
|
|
||
| let isCloudBuilderEnabled = containerProvider.config.gardenCloudBuilder?.enabled || false | ||
|
|
||
| // The env variable GARDEN_CLOUD_BUILDER can be used to override the cloudbuilder.enabled config setting. |
There was a problem hiding this comment.
The setting name seems to be gardenCloudBuilder.enabled.
| }) | ||
|
|
||
| // public API | ||
| export const cloudbuilder = { |
There was a problem hiding this comment.
Let's rename this to cloudBuilder.
|
Thank you! 👍 The comments above are not critical and can be addressed in a follow-up PR. |
What this PR does / why we need it:
Experimental cloudbuilder support for alpha preview users.
Which issue(s) this PR fixes:
Implements Garden Cloud Builder support, but also Fixes #5437
Special notes for your reviewer:
Tests are missing. I'd like to start dogfooding and validating this, and then implement tests before we make it generally available.